Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Megamenu restriction on access levels #128

Conversation

Sophist-UK
Copy link
Contributor

No description provided.

@Sophist-UK
Copy link
Contributor Author

Currently megamenu assumes (correctly for the limited set of access levels supported) that each access level has access to all menus of the access level below. The code does not work out correctly which menus are accessible by the specific access level selected - and this is presumably why we have this restriction.

So I need to add further code to megamenu.php to correctly check the menu's access levels and provide that in the ajax response. More news later.

@Sophist-UK
Copy link
Contributor Author

Ok - I have fixed this completely - Megamenus can now be used with any view / access level.

As stated above, it might be better to use the user group as the dropdown, and display the menu items that would be seen by a user in that usergroup, however that is left for future enhancement by someone else.

This fix displays the menus associated with the view level selected as
per J2.5/J3 view level model.

A further improvement might be to use the usergroup as the dropdown and
display the menus as seen by a user in that group, however this would be
an enhancement rather than a fix,  and is outside the scope of this fix.
@locii
Copy link
Contributor

locii commented Aug 6, 2013

Cool thanks for this :)

@Sophist-UK
Copy link
Contributor Author

I note that 4 weeks later and this fix has still not been merged - nor has anyone from joomlart even commented on it.

Having put the effort into identifying the issue, tracking down the cause and creating a fix, it would be nice if someone from joomlart had the courtesy at least to review and comment on it.

S

@joomlart
Copy link
Contributor

Hi Sophist-UK,

Thank for you looking at this issue.
Though, your fix is just open another case of error that we have try to restrict, and it does not really fix the problem.

We will wait for another complete solutions for Megamenu.

@joomlart joomlart closed this Aug 29, 2013
@Sophist-UK
Copy link
Contributor Author

It would be helpful if, rather than simply closing this, you could instead explain what error still remains so I can see if I can fix it.

@bjoe2k4
Copy link
Contributor

bjoe2k4 commented Apr 23, 2014

Any update on this?

@Sophist-UK
Copy link
Contributor Author

Because of the difficulties I faced in getting the issues I found fixed, I have switched to a different framework / template. So, sorry, but I am not working on fixing this.

@bjoe2k4
Copy link
Contributor

bjoe2k4 commented Apr 23, 2014

Do you remember the issues roughly? It shouldn't be so difficult to add all access levels instead of the 3 levels that originate from Joomla 1.5.

Just out of curiosity, to which framework/template you switched?

Any update from Joomlart?

@Sophist-UK
Copy link
Contributor Author

I provided a partial update, but the response from the t3 folks was very dismissive - effectively saying that it was "impossible to support the full J2 user levels and why would anyone want any more than the standard J1.5 ones anyway".

@croatian-coast
Copy link

This is causing me problems too, I have had to refine the member ACL to few more detailed membership groups, and due to this I cant use the megamenu function in my site, which is a shame. Since I can only set settings for the default Joomla groups, and the newly created ones don’t show in options.

Where this would be helpful, well when I want to show splash screen per access levels, ie. Which for me are memberships.

So please allow this to be fixed.

From: Sophist [mailto:notifications@github.com]
Sent: Wednesday, April 23, 2014 7:21 PM
To: t3framework/t3
Subject: Re: [t3] Remove Megamenu restriction on access levels (#128)

I provided a partial update, but the response from the t3 folks was very dismissive - effectively saying that it was "impossible to support the full J2 user levels and why would anyone want any more than the standard J1.5 ones anyway".


Reply to this email directly or view it on GitHub #128 (comment) .

@Sophist-UK
Copy link
Contributor Author

I am not stopping this from being fixed - the Joomlart people are doing that. I am just not going to put the effort into writing a fix when the Joomlart people have made it clear that they don't want it and won't merge it!

@xycofryx
Copy link

@Sophist-UK - you're the man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants